Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong macos target in release CI #139

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix wrong macos target in release CI #139

merged 2 commits into from
Nov 12, 2024

Conversation

lv37
Copy link
Contributor

@lv37 lv37 commented Nov 12, 2024 •
edited
Loading

Both the macos-arm64 and macos-x86_64 targets were building arm64 binaries. This fixes it.

@lv37
Copy link
Contributor Author

lv37 commented Nov 12, 2024

The failing Install CI check is probably unrelated.

spytheman
spytheman approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.
Using an explicit build target is indeed better.
Thank you.

@spytheman
Copy link
Member

The install CI error is now fixed on the main branch.

@spytheman spytheman merged commit 8f1a06b into vlang:main Nov 12, 2024
15 of 16 checks passed
@lv37 lv37 deleted the patch-macos-ci branch November 13, 2024 12:01
lv37 added a commit to lv37/v-analyzer that referenced this pull request Nov 13, 2024
@lv37
Fix wrong macos target in release CI (vlang#139)
8bcfb7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lv37 @spytheman